-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ReadTheDocs #1328
Conversation
@tburrows13 registered to ReadTheDocs (under username Zulko), I can see the moviepy project there, with an August build failing because of a numpydoc requirement (which this PR solves if I understand correctly). Let me know what the next steps are. |
Thanks @Zulko. I've added you as a 'maintainer' on readthedocs (though perhaps this wasn't needed because it knows that you own the associated github repo). Can you please go to "Admin" > "Integrations" > "Add Integration" > Type="Github incoming webhook". That should be all that is required, and I can adjust the settings from there. (It should still fail the first build because this PR hasn't yet been merged, but it will then rebuild on every commit) |
Done 👍 |
That looks like it worked, thanks! |
I definitely plan to play around with the theming/style a bit more (on top of the many text improvements needed), but it is now viewable at moviepy.readthedocs.io, and you can switch to the 1.0.x branch at the bottom. I'm not in a rush to transition from the current docs. |
That's great but I noticed that the Moviepy docs now have inserted ads, which is sad. Apparently I could pay 60$/year to remove them, but that's a bummer. Is readthedocs worth it? Would there be a way to get similar auto-deployment features using github actions? |
Yeah, the ads are unfortunate. The readthedocs autobuilding will be very useful for quick feedback whilst I rework the docs, but yes, there’s actually no reason why we shouldn’t then try autobuilding into gh-pages later. I don’t think we’d get the multiple doc instance selector which is pretty neat, but perhaps on release of v2.0 we could then keep the gh pages up-to-date with the latest master automatically and link to a readthedocs instance for people who still need legacy? |
Adding the correct link here (the one above is wonky): https://moviepy.readthedocs.io/en/latest/ |
Btw. IIRC, GitHub's now made it possible to use other branches than |
Yep.
|
I like the long-term solution of having rtd only for legacy versions. In the meantime, whathever makes your life easier during the v2 transition 👍 |
I've been planning documentation improvements for a while, and I'd like to switch to using readthedocs to host them. This means that any changes made to master will be instantly reflected in the documentation with no extra effort required from maintainers, and it comes with easy options for users to switch to an older snapshot of the docs. I'll also merge this change into the v1.0.x branch so that will always be available in its current form.
The URL will be moviepy.readthedocs.io, but I need @Zulko to enable the githook to allow auto-creation of the docs. Would you mind linking your account to https://readthedocs.org? Then I can add you as a maintainer to the moviepy readthedocs project and then you can link it to this GitHub repo.